Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimentalSelfManagedUpgrade flag for management cluster controller #6888

Merged

Conversation

panktishah26
Copy link
Member

Description of changes:
Remove experimentalSelfManagedUpgrade flag and allow management cluster's worker nodes and control plane both to reconcile.

Testing (if applicable):
Tested cluster upgrade using CLI for docker and vSphere provider.

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2023
@panktishah26
Copy link
Member Author

/cherrypick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff55ac1) 71.96% compared to head (4287644) 71.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6888      +/-   ##
==========================================
- Coverage   71.96%   71.95%   -0.02%     
==========================================
  Files         532      532              
  Lines       41601    41593       -8     
==========================================
- Hits        29938    29927      -11     
- Misses       9987     9989       +2     
- Partials     1676     1677       +1     
Files Coverage Δ
controllers/cluster_controller.go 75.92% <100.00%> (-1.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat
Copy link
Member

tatlat commented Oct 25, 2023

/lgtm

@tatlat
Copy link
Member

tatlat commented Oct 25, 2023

/approve
/woof

@eks-distro-bot
Copy link
Collaborator

@tatlat: dog image

In response to this:

/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request created: #6889

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants