-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimentalSelfManagedUpgrade flag for management cluster controller #6888
Remove experimentalSelfManagedUpgrade flag for management cluster controller #6888
Conversation
/cherrypick release-0.18 |
@panktishah26: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6888 +/- ##
==========================================
- Coverage 71.96% 71.95% -0.02%
==========================================
Files 532 532
Lines 41601 41593 -8
==========================================
- Hits 29938 29927 -11
- Misses 9987 9989 +2
- Partials 1676 1677 +1
☔ View full report in Codecov by Sentry. |
/lgtm |
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tatlat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@panktishah26: new pull request created: #6889 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Remove experimentalSelfManagedUpgrade flag and allow management cluster's worker nodes and control plane both to reconcile.
Testing (if applicable):
Tested cluster upgrade using CLI for docker and vSphere provider.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.