Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest minor version issue in docker skip cilium upgrade E2E #6894

Merged

Conversation

rahulbabu95
Copy link
Member

@rahulbabu95 rahulbabu95 commented Oct 25, 2023

Cilium Skip Upgrade tests fail when run against the release branch when the release isn't out already as it picks up the wrong latest minor version. Make the test to derive at the latest minor based on the test branch it is run against to rightly calculate the previous latest minor release.

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2023
@rahulbabu95 rahulbabu95 changed the title Fix latest minor version issue in cilium skip install docker upgrade … Fix latest minor version issue in docker skip cilium upgrade E2E Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff55ac1) 71.96% compared to head (9b10bdd) 71.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6894      +/-   ##
==========================================
- Coverage   71.96%   71.94%   -0.02%     
==========================================
  Files         532      532              
  Lines       41601    41593       -8     
==========================================
- Hits        29938    29924      -14     
- Misses       9987     9991       +4     
- Partials     1676     1678       +2     
Files Coverage Δ
controllers/cluster_controller.go 75.92% <100.00%> (-1.28%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahreehong
Copy link
Member

/retest

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 3b66dbe into aws:main Oct 25, 2023
5 checks passed
@rahulbabu95
Copy link
Member Author

/cherrypick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@rahulbabu95: new pull request created: #6897

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants