-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix latest minor version issue in docker skip cilium upgrade E2E #6894
Fix latest minor version issue in docker skip cilium upgrade E2E #6894
Conversation
…tests Signed-off-by: Rahul Ganesh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6894 +/- ##
==========================================
- Coverage 71.96% 71.94% -0.02%
==========================================
Files 532 532
Lines 41601 41593 -8
==========================================
- Hits 29938 29924 -14
- Misses 9987 9991 +4
- Partials 1676 1678 +2
☔ View full report in Codecov by Sentry. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.18 |
@rahulbabu95: new pull request created: #6897 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cilium Skip Upgrade tests fail when run against the release branch when the release isn't out already as it picks up the wrong latest minor version. Make the test to derive at the latest minor based on the test branch it is run against to rightly calculate the previous latest minor release.
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.