Revert "Set etcd url in cloud-config when external etcd is enabled"

[tatlat]

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[g-gaston]

/lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa0e358) 71.95% compared to head (a79f136) 71.94%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6902      +/-   ##
==========================================
- Coverage   71.95%   71.94%   -0.01%     
==========================================
  Files         532      532              
  Lines       41593    41583      -10     
==========================================
- Hits        29927    29917      -10     
  Misses       9989     9989              
  Partials     1677     1677              

Files	Coverage Δ
pkg/cluster/spec.go	94.33% <100.00%> (-0.18%)	⬇️
pkg/clusterapi/etcd.go	85.36% <100.00%> (-0.35%)	⬇️
pkg/providers/cloudstack/template.go	88.58% <ø> (-0.04%)	⬇️
pkg/providers/docker/docker.go	71.36% <ø> (-0.07%)	⬇️
pkg/providers/snow/apibuilder.go	90.15% <100.00%> (ø)
pkg/providers/tinkerbell/template.go	67.74% <ø> (-0.07%)	⬇️
pkg/providers/vsphere/template.go	78.21% <ø> (-0.07%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tatlat]

/approve

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tatlat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tatlat]

/cherry-pick release-0.18

[eks-distro-pr-bot]

@tatlat: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eks-distro-pr-bot]

@tatlat: new pull request created: #6903

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.