Replace deprecated patchesStrategicMerge with patches in flux kustomization
#7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
|
/lgtm |
tatlat
approved these changes
Dec 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7207 +/- ##
==========================================
- Coverage 71.59% 71.59% -0.01%
==========================================
Files 548 548
Lines 42532 42521 -11
==========================================
- Hits 30452 30441 -11
Misses 10386 10386
Partials 1694 1694 ☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiayiwang7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When EKS-A executing
flux bootstrapfailed with error:❌ Error when installing GitOps toolkits on workload cluster; EKS-A will continue with cluster creation, but GitOps will not be enabled {"error": "installing GitHub gitops: executing flux bootstrap github: ► connecting to github.com\n► cloning branch \"main\" from Git repository \"https://github.com/tatlat/testGitopsRepo-.git\"\n✔ cloned repository\n► generating component manifests\n✔ generated component manifests\n✔ component manifests are up to date\n✔ reconciled components\n► determining if source secret \"default/flux-system\" exists\n✔ source secret up to date\n► generating sync manifests\n✔ generated sync manifests\n✔ sync manifests are up to date\n► applying sync manifests\n# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.\n✔ reconciled sync configuration\n◎ waiting for Kustomization \"default/default\" to be reconciled\n✔ Kustomization reconciled successfully\n► confirming components are healthy\n✗ helm-controller: deployment not ready\n✔ kustomize-controller: deployment ready\n✔ notification-controller: deployment ready\n✔ source-controller: deployment ready\n✗ bootstrap failed with 1 health check failure(s)\n"}The helm controller is in crashing loop with error stating not able to find
helm.toolkit.fluxcd.io/v2beta2API resource:This is caused by EKS-A dev build uses Flux CLI v2.1.x which is not compatible with the helm controller image v0.37.x: the Flux v2.1.x does not install
helm.toolkit.fluxcd.io/v2beta2API version CRD which is required in the helm controller v0.37.x.Description of changes:
In order to solve the problem, we need to bump the Flux CLI version to v2.2.x and make sure all the Flux controllers version are compatible with it based of: https://github.com/fluxcd/flux2/releases. @abhay-krishna will follow up a PR in build tooling repo to bump the versions.
This PR only solves the warning message in the CLI
Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.We replace the deprecatedpatchesStrategicMergewithpatchesin flux system kustomization.Testing (if applicable):
--- PASS: TestDockerKubernetes128GithubFlux (961.03s)Documentation added/planned (if applicable):
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.