Allow mgmt create via controller if managed by cli #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7210 +/- ##
==========================================
+ Coverage 71.56% 71.60% +0.03%
==========================================
Files 545 548 +3
Lines 42323 42548 +225
==========================================
+ Hits 30288 30466 +178
- Misses 10343 10388 +45
- Partials 1692 1694 +2 ☔ View full report in Codecov by Sentry. |
tatlat
force-pushed
the
flc-unification-annotations
branch
from
489c31d to
b59c7de
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tatlat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The unification of the controller and CLI requires the ability to create mgmt clusters via the controller. However, we should only allow this creation when it's initiated by the CLI.
Description of changes:
Modifies webhook create validations to return an error for self-managed clusters only if the managed-by-cli annotation is not present.
Testing (if applicable):
Manually created mgmt clusters with CLI (both old and new workflows) and FLC.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.