-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow E2E tests for individual providers to be kicked off from CodeBuild #7229
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7229 +/- ##
=======================================
Coverage 71.69% 71.69%
=======================================
Files 548 548
Lines 42789 42789
=======================================
Hits 30676 30676
Misses 10407 10407
Partials 1706 1706 ☔ View full report in Codecov by Sentry. |
/cherrypick release-0.18 |
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
38c9c3b
to
bb04044
Compare
New changes are detected. LGTM label has been removed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/override eks-anywhere-e2e-presubmit |
@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-e2e-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhay-krishna: new pull request created: #7230 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In the E2E pipelines, the build stage builds all the binaries required for the tests and then passes them through to the test stage, so they're available in test stage only when run through the pipeline. This also means you can't trigger E2E tests for individual providers since triggering the pipeline will make it run all the provider E2E tests. This PR allows them to be run standalone as a CodeBuild job by building the binaries in situ in the test stage if the initiator is not CodePipeline.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.