Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify eksarelease exists on mgmt cluster #7231

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Dec 22, 2023

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c1479be) 71.69% compared to head (03806e4) 71.73%.
Report is 6 commits behind head on main.

Files Patch % Lines
cmd/eksctl-anywhere/cmd/createcluster.go 0.00% 4 Missing ⚠️
controllers/cluster_controller.go 83.33% 2 Missing and 1 partial ⚠️
cmd/eksctl-anywhere/cmd/upgradecluster.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7231      +/-   ##
==========================================
+ Coverage   71.69%   71.73%   +0.04%     
==========================================
  Files         548      552       +4     
  Lines       42789    42938     +149     
==========================================
+ Hits        30676    30801     +125     
- Misses      10407    10430      +23     
- Partials     1706     1707       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2023
pkg/cluster/builder.go Outdated Show resolved Hide resolved
pkg/executables/kubectl.go Outdated Show resolved Hide resolved
pkg/validations/cluster.go Outdated Show resolved Hide resolved
pkg/validations/createvalidations/preflightvalidations.go Outdated Show resolved Hide resolved
pkg/cluster/builder.go Outdated Show resolved Hide resolved
pkg/validations/upgradevalidations/preflightvalidations.go Outdated Show resolved Hide resolved
pkg/validations/createvalidations/preflightvalidations.go Outdated Show resolved Hide resolved
@tatlat tatlat marked this pull request as ready for review December 27, 2023 22:40
controllers/cluster_controller.go Outdated Show resolved Hide resolved
controllers/cluster_controller.go Outdated Show resolved Hide resolved
controllers/cluster_controller_test.go Outdated Show resolved Hide resolved
controllers/cluster_controller_test.go Show resolved Hide resolved
pkg/validations/cluster.go Outdated Show resolved Hide resolved
pkg/validations/cluster.go Outdated Show resolved Hide resolved
controllers/cluster_controller_test.go Outdated Show resolved Hide resolved
controllers/cluster_controller_test.go Outdated Show resolved Hide resolved
Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tatlat
Copy link
Member Author

tatlat commented Jan 2, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit b84f94b into aws:main Jan 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants