Add e2e test for upgrading management-components #7251
Conversation
eks-distro-bot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7251 +/- ##
=======================================
Coverage 71.63% 71.64%
=======================================
Files 556 556
Lines 43199 43199
=======================================
+ Hits 30945 30948 +3
+ Misses 10543 10541 -2
+ Partials 1711 1710 -1 ☔ View full report in Codecov by Sentry. |
d8660091
changed the title
d8660091
force-pushed
the
e2e-upgrade-management-components-2
branch
from
a8fccd1 to
7453ba6
Compare
d8660091
force-pushed
the
e2e-upgrade-management-components-2
branch
from
7453ba6 to
40b4bc0
Compare
d8660091
changed the title
| // create cluster with old eksa | ||
| test.CreateCluster(framework.ExecuteWithEksaRelease(release)) | ||
| // upgrade management-components with new eksa | ||
| test.RunEKSA([]string{"upgrade", "management-components", "-f", test.ClusterConfigLocation, "-v", "99"}) |
There was a problem hiding this comment.
nit: I think that we should we create a test.UpgradeManagmentComponents function and hide these details.
Because the followup procedure of upgrading the cluster itself will fail due to the bug: https://github.com/aws/eks-anywhere-internal/issues/2126. And I think right now we need a test case to cover the most essential flow of the new subcommand more than we need a comprehensive one that verify the flow of eksa controller reconciliation process. Having said that, we can do this in another PR when the bug is fixed |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: d8660091 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
Testing (if applicable): Manually invoked the new e2e test, and it passed.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.