Improve Binary Installation Process for K8s Tools #7252
Conversation
eks-distro-bot
added
the
size/XS
|
/lgtm |
|
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7252 +/- ##
=======================================
Coverage 71.63% 71.64%
=======================================
Files 556 556
Lines 43199 43199
=======================================
+ Hits 30945 30948 +3
+ Misses 10543 10541 -2
+ Partials 1711 1710 -1 ☔ View full report in Codecov by Sentry. |
|
@abhay-krishna: new pull request created: #7254 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
The method for installing the eksctl and associated commands is not secure as it creates a file in a system-wide directory owned by a user (user = whoever the person is logged in as).
Description of changes:
Cleanup aligned with previous PR
#5680
Instead of using mv (and chmod in some of the examples), use the "install" command with appropriate flags
ex - replace first line (mv) with the second (install)
sudo mv /tmp/eksctl /usr/local/bin/
sudo install -m 0755 /tmp/eksctl /usr/local/bin/eksctl
Testing (if applicable):
Documentation added/planned (if applicable):
N/A - this is an upd ate, not an add.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.