Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mgmt cluster using controller #7253

Closed
wants to merge 9 commits into from
Closed

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Jan 4, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tatlat. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 450 lines in your changes are missing coverage. Please review.

Comparison is base (6eee9ff) 71.75% compared to head (3ab1169) 70.89%.
Report is 10 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_cluster.go 0.00% 91 Missing ⚠️
...lows/management/create_ install_eksa_components.go 0.00% 63 Missing ⚠️
pkg/clustermanager/cluster_creator.go 0.00% 62 Missing ⚠️
pkg/clustermanager/cluster_manager.go 0.00% 45 Missing ⚠️
cmd/eksctl-anywhere/cmd/createcluster.go 0.00% 36 Missing ⚠️
pkg/workflows/management/create.go 0.00% 28 Missing ⚠️
pkg/workflows/management/validate.go 12.50% 28 Missing ⚠️
pkg/workflows/management/create_move_capi.go 0.00% 23 Missing ⚠️
...g/workflows/management/create_install_resources.go 0.00% 17 Missing ⚠️
pkg/workflows/management/delete_bootstrap.go 0.00% 17 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7253      +/-   ##
==========================================
- Coverage   71.75%   70.89%   -0.86%     
==========================================
  Files         554      565      +11     
  Lines       43015    43645     +630     
==========================================
+ Hits        30864    30941      +77     
- Misses      10445    10993     +548     
- Partials     1706     1711       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 5, 2024
@tatlat tatlat closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants