Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate kubeconfig operations from cluster manager #7267

Merged
merged 1 commit into from
Jan 17, 2024

add clustercreator and kubeconfig writer

9209b52
Select commit
Loading
Failed to load commit list.
Merged

Separate kubeconfig operations from cluster manager #7267

add clustercreator and kubeconfig writer
9209b52
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2024 in 0s

71.71% (+0.07%) compared to a99d4da

View this Pull Request on Codecov

71.71% (+0.07%) compared to a99d4da

Details

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a99d4da) 71.64% compared to head (9209b52) 71.71%.
Report is 12 commits behind head on main.

Files Patch % Lines
pkg/clustermanager/cluster_creator.go 72.72% 6 Missing and 3 partials ⚠️
cmd/eksctl-anywhere/cmd/createcluster.go 0.00% 4 Missing ⚠️
pkg/kubeconfig/kubeconfig_writer.go 93.61% 2 Missing and 1 partial ⚠️
pkg/providers/docker/docker.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7267      +/-   ##
==========================================
+ Coverage   71.64%   71.71%   +0.07%     
==========================================
  Files         556      559       +3     
  Lines       43190    43368     +178     
==========================================
+ Hits        30943    31101     +158     
- Misses      10537    10551      +14     
- Partials     1710     1716       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov