Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify IRSA can be configure via upgrade #7287

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Clarify IRSA can be configure via upgrade #7287

merged 1 commit into from
Jan 11, 2024

Conversation

chrisdoherty4
Copy link
Contributor

No description provided.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (025d06f) 71.63% compared to head (0bf335f) 71.64%.

❗ Current head 0bf335f differs from pull request most recent head 715d13d. Consider uploading reports for the commit 715d13d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7287   +/-   ##
=======================================
  Coverage   71.63%   71.64%           
=======================================
  Files         556      556           
  Lines       43204    43204           
=======================================
+ Hits        30949    30952    +3     
+ Misses      10544    10542    -2     
+ Partials     1711     1710    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisdoherty4
Copy link
Contributor Author

/approve
/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@chrisdoherty4: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a4fc7a6 into aws:main Jan 11, 2024
7 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@chrisdoherty4: #7287 failed to apply on top of branch "release-0.18":

Applying: Clarify IRSA can be configure via upgrade
Using index info to reconstruct a base tree...
M	docs/content/en/docs/getting-started/optional/irsa.md
Falling back to patching base and 3-way merge...
Auto-merging docs/content/en/docs/getting-started/optional/irsa.md
CONFLICT (content): Merge conflict in docs/content/en/docs/getting-started/optional/irsa.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Clarify IRSA can be configure via upgrade
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/approve
/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants