adding nutanix upgrade rollout strategy #7316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7316 +/- ##
=======================================
Coverage 71.72% 71.72%
=======================================
Files 559 559
Lines 43368 43377 +9
=======================================
+ Hits 31104 31113 +9
Misses 10549 10549
Partials 1715 1715 ☔ View full report in Codecov by Sentry. |
g-gaston
reviewed
Jan 17, 2024
| t.Setenv(constants.EksaNutanixUsernameKey, "admin") | ||
| t.Setenv(constants.EksaNutanixPasswordKey, "password") | ||
| creds := GetCredsFromEnv() | ||
| builder := NewNutanixTemplateBuilder(&dcConf.Spec, &machineConf.Spec, &machineConf.Spec, workerConfs, creds, time.Now) |
There was a problem hiding this comment.
same comment about testing this from a different place that I made for docker
raymond-zhang00
force-pushed
the
add-nutanix-upgrade-rollout-strategy
branch
from
04e35e3 to
6791d46
Compare
eks-distro-bot
added
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raymond-zhang00 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#6719
Description of changes:
Adding UpgradeRolloutStrategy knobs for workers and control plane to nutanix provider
Testing (if applicable):
Updated unit tests.
Documentation added/planned (if applicable):
Planning on adding docs on knobs for other providers following the Tinkerbell upgrade strategy format.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.