Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cilium kube-proxy replacement support #7322

Closed
wants to merge 1 commit into from
Closed

Add Cilium kube-proxy replacement support #7322

wants to merge 1 commit into from

Conversation

chrisdoherty4
Copy link
Contributor

Cilium can take ownership of all kube-proxy responsibilities. In Cilium v1.13 there are partial and strict modes, however the API changes in v1.14 to a binary setting so this support is for v1.13 strict mode only.

Cilium can take ownership of all kube-proxy responsibilities. In Cilium
v1.13 there are partial and strict modes, however the API changes in
v1.14 to a binary setting so this support is for v1.13 strict mode only.
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrisdoherty4. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (18094e9) 71.64% compared to head (795bf24) 71.71%.
Report is 18 commits behind head on main.

Files Patch % Lines
pkg/networking/cilium/templater.go 0.00% 5 Missing and 1 partial ⚠️
pkg/api/v1alpha1/cluster_types.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7322      +/-   ##
==========================================
+ Coverage   71.64%   71.71%   +0.06%     
==========================================
  Files         556      559       +3     
  Lines       43190    43382     +192     
==========================================
+ Hits        30943    31110     +167     
- Misses      10537    10556      +19     
- Partials     1710     1716       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +310 to +314
{{- with .kubeadmSkipPhases }}
skipPhases:
{{- range . }}
- {{ . }}
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious. Why was this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is skipPhases needed or why is end?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipPhases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants