Update K8s version on Capi machine for in-place upgrades #7325
Conversation
eks-distro-bot
added
the
size/S
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7325 +/- ##
==========================================
- Coverage 71.77% 71.75% -0.03%
==========================================
Files 560 560
Lines 43495 43513 +18
==========================================
+ Hits 31220 31223 +3
- Misses 10556 10566 +10
- Partials 1719 1724 +5 ☔ View full report in Codecov by Sentry. |
eks-distro-bot
added
size/L
Signed-off-by: Rahul Ganesh <[email protected]>
Signed-off-by: Rahul Ganesh <[email protected]>
Signed-off-by: Rahul Ganesh <[email protected]>
Signed-off-by: Rahul Ganesh <[email protected]>
rahulbabu95
force-pushed
the
inplace/update-capi-machine-version
branch
from
481607c to
a518b9d
Compare
eks-distro-bot
added
size/M
Signed-off-by: Rahul Ganesh <[email protected]>
| log.Info("Updating K8s version in machine", "Machine", machine.Name) | ||
| machine.Spec.Version = &nodeUpgrade.Spec.KubernetesVersion | ||
| if err := machinePatchHelper.Patch(ctx, machine); err != nil { | ||
| return fmt.Errorf("updating status for machine %s: %v", machine.Name, err) |
There was a problem hiding this comment.
| return fmt.Errorf("updating status for machine %s: %v", machine.Name, err) | |
| return fmt.Errorf("updating spec for machine %s: %v", machine.Name, err) |
Right?
Signed-off-by: Rahul Ganesh <[email protected]>
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override codecov/patch |
|
@rahulbabu95: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
In-place upgrades directly upgrades the K8s components outside of the capi upgrade flow. This requires updating the K8s version on the capi objects once the in-place upgrade has been done to reflect the updated k8s version on the node. This change updates the K8s version on the capi machine once the nodeupgrader object has completed the upgrade on the node associated with the corresponding capi machine for the controlplane nodes.
Description of changes:
Testing (if applicable):
Manually tested with updating the KCP controller image with one that accommodates InPlace as upgrade strategy type.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.