Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-place upgrade controllers for kcp and md #7327

Closed
wants to merge 1 commit into from

Conversation

vivek-koppuru
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from vivek-koppuru. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 249 lines in your changes are missing coverage. Please review.

Comparison is base (5a474bf) 71.72% compared to head (0ad288e) 71.36%.
Report is 39 commits behind head on main.

❗ Current head 0ad288e differs from pull request most recent head 29268db. Consider uploading reports for the commit 29268db to get more accurate results

Files Patch % Lines
...s/kubeadmcontrolplane_inplaceupgrade_controller.go 0.00% 129 Missing ⚠️
...ers/machinedeployment_inplaceupgrade_controller.go 0.00% 98 Missing ⚠️
controllers/factory.go 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7327      +/-   ##
==========================================
- Coverage   71.72%   71.36%   -0.36%     
==========================================
  Files         559      562       +3     
  Lines       43368    43744     +376     
==========================================
+ Hits        31104    31220     +116     
- Misses      10549    10805     +256     
- Partials     1715     1719       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vivek-koppuru vivek-koppuru force-pushed the inplace-controllers branch 3 times, most recently from 67b51b7 to 0ad288e Compare January 20, 2024 01:23
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2024
@vivek-koppuru
Copy link
Member Author

vivek-koppuru commented Jan 23, 2024

Separating the PRs into kcp and md

KCP: #7361
MD: #7369

@vivek-koppuru vivek-koppuru deleted the inplace-controllers branch January 26, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants