Handle CLI tagging when latest tag is of n-1 branch #8530
Conversation
Signed-off-by: Rahul Ganesh <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/S
Signed-off-by: Rahul Ganesh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8530 +/- ##
=======================================
Coverage 73.50% 73.50%
=======================================
Files 578 578
Lines 36531 36531
=======================================
Hits 26853 26853
Misses 7956 7956
Partials 1722 1722 ☔ View full report in Codecov by Sentry. |
|
/hold |
|
|
||
| # Query to check if the latest_tag is of n'th branch. | ||
| # For ex, if the latest release is of n-1 branch, we need to ignore that tag and find the next branch. | ||
| latest_minor=$(echo "${latest_tag}" | cut -d "." -f 2) |
There was a problem hiding this comment.
| latest_minor=$(echo "${latest_tag}" | cut -d "." -f 2) | |
| latest_minor=$(( $(echo "${latest_tag}" | cut -d "." -f 2) + 1 )) |
nit: could combine it into one line and accurately name the var
|
This issue has been fixed in a separate PR |
Description of changes:
When a 'n-1' version of eks-a is released, the script responsible for tagging the dev CLI pulls in the latest tag, bumps it by 1 to arrive at the next Dev tag for the CLI. This had worked fine until we supported for release branch n. With n-1 support, we need to factor in if the latest release is of 'n-1' and ignore it during the dev tagging.
Testing:
Ran the make eks-a command before and after this change to see the Dev CLI tag.
Before:
/Library/Developer/CommandLineTools/usr/bin/make eks-a-binary GIT_VERSION=v0.20.0-dev+latestAfter:
/Library/Developer/CommandLineTools/usr/bin/make eks-a-binary GIT_VERSION=v0.21.0-dev+latestBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.