Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update image-builder docs #8552

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Jul 29, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tatlat. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.52%. Comparing base (69f4827) to head (e31e1bf).
Report is 131 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8552   +/-   ##
=======================================
  Coverage   73.52%   73.52%           
=======================================
  Files         578      578           
  Lines       36549    36549           
=======================================
  Hits        26873    26873           
  Misses       7955     7955           
  Partials     1721     1721           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat tatlat self-assigned this Aug 5, 2024
@mitalipaygude
Copy link
Member

Can we add description details on this PR?

@sp1999 sp1999 added this to the v0.21.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants