Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a random subnet id from a list of subnet ids #9042

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

panktishah26
Copy link
Member

Description of changes:

Our e2e tests are failing with the below error,

InsufficientInstanceCapacity: We currently do not have sufficient t3.2xlarge capacity in the Availability Zone you requested (***a). Our system will be working on provisioning additional capacity. You can currently get t3.2xlarge capacity by not specifying an Availability Zone in your request or choosing ***b, ***c, ***d.

Getting a random subnet id from the string containing multiple subnet ids to fix the above issue.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (195ea65) to head (f58377c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/ec2/create.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9042      +/-   ##
==========================================
- Coverage   72.42%   72.41%   -0.01%     
==========================================
  Files         578      578              
  Lines       45403    45406       +3     
==========================================
  Hits        32883    32883              
- Misses      10790    10793       +3     
  Partials     1730     1730              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@panktishah26 panktishah26 merged commit a862cd2 into aws:main Dec 5, 2024
10 of 12 checks passed
@panktishah26 panktishah26 deleted the get-subnet-from-list branch December 6, 2024 01:12
@panktishah26 panktishah26 restored the get-subnet-from-list branch December 7, 2024 00:32
@panktishah26
Copy link
Member Author

/cherry-pick release-0.20
/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request created: #9055

In response to this:

/cherry-pick release-0.20
/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@panktishah26
Copy link
Member Author

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request could not be created: failed to create pull request against aws/eks-anywhere#release-0.20 from head eks-distro-pr-bot:cherry-pick-9042-to-release-0.20: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for eks-distro-pr-bot:cherry-pick-9042-to-release-0.20."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-0.20
/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request created: #9056

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants