Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.21] fix iam kubeconfig generation in workload clusters #9049

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #9048

/assign tatlat

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2024
@ahreehong
Copy link
Member

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahreehong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tatlat
Copy link
Member

tatlat commented Dec 6, 2024

/ok-to-test

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-0.21@d5c53a1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/clustermanager/cluster_manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.21    #9049   +/-   ##
===============================================
  Coverage                ?   72.36%           
===============================================
  Files                   ?      578           
  Lines                   ?    45416           
  Branches                ?        0           
===============================================
  Hits                    ?    32866           
  Misses                  ?    10820           
  Partials                ?     1730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahreehong ahreehong merged commit 2cacade into aws:release-0.21 Dec 6, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants