-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support unknown resources #4828
Conversation
counterpart to kubernetes-sigs/karpenter#603
✅ Deploy Preview for karpenter-docs-prod canceled.
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
bump |
@universam1 could you fix the CI failures? |
@johngmyers Thanks for the reply - the changes in core kubernetes-sigs/karpenter#603 need to be merged first for this repo ci to pass. How can we attack this? |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
bump |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
@universam1 Looks like this PR still depends on the PR over in |
We're going to close out this PR for now to make sure we are just maintaining active PRs in our backlog. Given the fact that we are having discussion in kubernetes-sigs/karpenter#603 (comment) and in kubernetes-sigs/karpenter#751, I think we need to come to some resolution in how we handle this problem generically before we come to specific solutions in the cloud provider code. |
Description
depends on kubernetes-sigs/karpenter#603 - please follow this issue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.