Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support unknown resources #4828

Closed
wants to merge 1 commit into from
Closed

Conversation

universam1
Copy link

@universam1 universam1 commented Oct 13, 2023

Description

depends on kubernetes-sigs/karpenter#603 - please follow this issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@universam1 universam1 requested a review from a team as a code owner October 13, 2023 08:58
@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d8f504f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/652906b022235b0008a88c7c

@github-actions
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@universam1
Copy link
Author

bump

@johngmyers
Copy link

@universam1 could you fix the CI failures?

@universam1
Copy link
Author

@universam1 could you fix the CI failures?

@johngmyers Thanks for the reply - the changes in core kubernetes-sigs/karpenter#603 need to be merged first for this repo ci to pass. How can we attack this?

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@universam1
Copy link
Author

bump

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis
Copy link
Contributor

@universam1 Looks like this PR still depends on the PR over in kubernetes-sigs/karpenter. Looks like from the initial discussion that it would be good for you to come to WG next Monday 9am PST since this problem is complex and we could discuss more there: kubernetes-sigs/karpenter#603 (comment).

@jonathan-innis
Copy link
Contributor

We're going to close out this PR for now to make sure we are just maintaining active PRs in our backlog. Given the fact that we are having discussion in kubernetes-sigs/karpenter#603 (comment) and in kubernetes-sigs/karpenter#751, I think we need to come to some resolution in how we handle this problem generically before we come to specific solutions in the cloud provider code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-design Design required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants