test PR - do not merge: 6+ minute delay fix with CI #6615

AndrewSirenko · 2024-07-31T02:17:42Z

Fixes #N/A

Description

Real PR test: Ensure no 6+ minute delays for disrupted stateful workloads

How was this change tested?

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-07-31T02:17:57Z

✅ Deploy Preview for karpenter-docs-prod ready!

Name	Link
🔨 Latest commit	`e3e37cb`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66acf2afff387600080574de
😎 Deploy Preview	https://deploy-preview-6615--karpenter-docs-prod.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls · 2024-07-31T02:23:41Z

Pull Request Test Coverage Report for Build 10210505898

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 79.267%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	91.67%

Totals
Change from base Build 10210121837:	-0.01%
Covered Lines:	5972
Relevant Lines:	7534

💛 - Coveralls

AndrewSirenko · 2024-07-31T02:25:41Z

/karpenter snapshot

AndrewSirenko · 2024-07-31T02:28:42Z

/karpenter snapshot

njtran

/karpenter snapshot

github-actions · 2024-07-31T02:43:54Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-97458a82cdfed5e458f855aad75500bc527685d8.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-97458a82cdfed5e458f855aad75500bc527685d8" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

AndrewSirenko · 2024-07-31T04:24:06Z

/karpenter snapshot

engedaam

/karpenter snapshot

github-actions · 2024-07-31T14:34:56Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-f7ab003bddb3e94d6173ee7b27104b2ce3b6d7c6.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-f7ab003bddb3e94d6173ee7b27104b2ce3b6d7c6" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran

/karpenter snapshot

github-actions · 2024-07-31T18:29:57Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-592043036245e4497fe5f81f049df3e1a67994a6.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-592043036245e4497fe5f81f049df3e1a67994a6" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

engedaam

/karpenter snapshot

github-actions · 2024-07-31T20:54:38Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4b3f7690e17de4fd3918544b5985a14ab961b7dd.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4b3f7690e17de4fd3918544b5985a14ab961b7dd" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

AndrewSirenko · 2024-08-01T01:21:31Z

/karpenter snapshot

/shrug

I tried ¯\(ツ)/¯

jonathan-innis

/karpenter snapshot

github-actions · 2024-08-01T04:21:15Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-b23507854ad11e81f8ed061f3796f3d72d209ad7.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-b23507854ad11e81f8ed061f3796f3d72d209ad7" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran

/karpenter snapshot

jonathan-innis

/karpenter snapshot

github-actions · 2024-08-01T18:12:04Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-61ffa9f8d22ca158b4eb0fee401bbac9c264b502.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-61ffa9f8d22ca158b4eb0fee401bbac9c264b502" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

njtran

/karpenter snapshot

jonathan-innis

/karpenter snapshot

github-actions · 2024-08-02T05:24:29Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-db954dfdd9a9f55beed97fb18e8c4db1d33c2341.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-db954dfdd9a9f55beed97fb18e8c4db1d33c2341" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

/karpenter snapshot

github-actions · 2024-08-02T05:39:43Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-2602edfe2828ef1d1180f5c10ccd9cd4bf05b589.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-2602edfe2828ef1d1180f5c10ccd9cd4bf05b589" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

AndrewSirenko · 2024-08-02T14:38:14Z

@jonathan-innis I think when you force pushed, the karpenter version in go mod changed, and therefore my replace directive didn't work because I was pinning left-hand side version. I'll update my commit to not pin the karpenter version on left side of replace directive.

FYI the real test pr is test: Ensure no 6+ minute delays for disrupted stateful workloads, this is just an extra PR for easy testing.

…teful workloads

AndrewSirenko requested a review from a team as a code owner July 31, 2024 02:17

AndrewSirenko requested a review from jonathan-innis July 31, 2024 02:17

AndrewSirenko changed the title ~~test: 6+ minute delay fix with CI~~ test PR: 6+ minute delay fix with CI Jul 31, 2024

njtran reviewed Jul 31, 2024

View reviewed changes

AndrewSirenko force-pushed the consolidatione2es branch from a520347 to f7ab003 Compare July 31, 2024 14:08

engedaam reviewed Jul 31, 2024

View reviewed changes

njtran reviewed Jul 31, 2024

View reviewed changes

AndrewSirenko force-pushed the consolidatione2es branch from 5920430 to 2c6cc33 Compare July 31, 2024 20:37

engedaam reviewed Jul 31, 2024

View reviewed changes

AndrewSirenko force-pushed the consolidatione2es branch 2 times, most recently from 414d5cb to b235078 Compare August 1, 2024 01:15

jonathan-innis reviewed Aug 1, 2024

View reviewed changes

AndrewSirenko force-pushed the consolidatione2es branch from b235078 to 61ffa9f Compare August 1, 2024 18:04

njtran reviewed Aug 1, 2024

View reviewed changes

jonathan-innis reviewed Aug 1, 2024

View reviewed changes

njtran reviewed Aug 1, 2024

View reviewed changes

jonathan-innis force-pushed the consolidatione2es branch from 61ffa9f to db954df Compare August 2, 2024 05:20

jonathan-innis reviewed Aug 2, 2024

View reviewed changes

AndrewSirenko changed the title ~~test PR: 6+ minute delay fix with CI~~ test PR - do not merge: 6+ minute delay fix with CI Aug 2, 2024

AndrewSirenko force-pushed the consolidatione2es branch from 2602edf to ee97874 Compare August 2, 2024 14:51

AndrewSirenko added 3 commits August 2, 2024 10:51

chore: Add volumeattachments read rules to cluster role.

b56f480

test: Add e2e tests that ensure no 6+ minute delays for disrupted sta…

c0da808

…teful workloads

tmp: prove e2e storage tests work

e3e37cb

AndrewSirenko force-pushed the consolidatione2es branch from ee97874 to e3e37cb Compare August 2, 2024 14:52

AndrewSirenko closed this Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test PR - do not merge: 6+ minute delay fix with CI #6615

test PR - do not merge: 6+ minute delay fix with CI #6615

AndrewSirenko commented Jul 31, 2024 •

edited

Loading

netlify bot commented Jul 31, 2024 •

edited

Loading

coveralls commented Jul 31, 2024 •

edited

Loading

AndrewSirenko commented Jul 31, 2024

AndrewSirenko commented Jul 31, 2024

njtran left a comment

github-actions bot commented Jul 31, 2024

AndrewSirenko commented Jul 31, 2024

engedaam left a comment

github-actions bot commented Jul 31, 2024

njtran left a comment

github-actions bot commented Jul 31, 2024

engedaam left a comment

github-actions bot commented Jul 31, 2024

AndrewSirenko commented Aug 1, 2024

jonathan-innis left a comment

github-actions bot commented Aug 1, 2024

njtran left a comment

jonathan-innis left a comment

github-actions bot commented Aug 1, 2024

njtran left a comment

jonathan-innis left a comment

github-actions bot commented Aug 2, 2024

jonathan-innis left a comment

github-actions bot commented Aug 2, 2024

AndrewSirenko commented Aug 2, 2024 •

edited

Loading

test PR - do not merge: 6+ minute delay fix with CI #6615

test PR - do not merge: 6+ minute delay fix with CI #6615

Conversation

AndrewSirenko commented Jul 31, 2024 • edited Loading

netlify bot commented Jul 31, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod ready!

coveralls commented Jul 31, 2024 • edited Loading

Pull Request Test Coverage Report for Build 10210505898

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

AndrewSirenko commented Jul 31, 2024

AndrewSirenko commented Jul 31, 2024

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

AndrewSirenko commented Jul 31, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

njtran left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2024

AndrewSirenko commented Aug 1, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 1, 2024

njtran left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 1, 2024

njtran left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2024

AndrewSirenko commented Aug 2, 2024 • edited Loading

AndrewSirenko commented Jul 31, 2024 •

edited

Loading

netlify bot commented Jul 31, 2024 •

edited

Loading

coveralls commented Jul 31, 2024 •

edited

Loading

AndrewSirenko commented Aug 2, 2024 •

edited

Loading