Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: drop test for adding eks:eks-cluster-name tag key after restart #7375

Merged
merged 1 commit into from
Nov 13, 2024
Merged

test: drop test for adding eks:eks-cluster-name tag key after restart #7375

merged 1 commit into from
Nov 13, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Dropping test for adding eks:eks-cluster-name tag key after restart in response to the change made here - 8ae2b8c

How was this change tested?
NA

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner November 13, 2024 22:46
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit f3d829f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67352c337f29d600084a2e13

engedaam
engedaam approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11827138762

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.691%
Totals Coverage Status
Change from base Build 11824274055: 0.0%
Covered Lines: 5666
Relevant Lines: 6852
💛 - Coveralls

@jigisha620 jigisha620 merged commit fd10545 into aws:main Nov 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@edibble21 edibble21 Awaiting requested review from edibble21 edibble21 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jigisha620 @coveralls @engedaam