Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use defined tag variables in labels.go #7380

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Update our labels.go to have defined tag variables in it. This cleans-up a weird cross-over that we had between labels and tags where it was difficult to delineate what a change in one would cause to the other

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1fd77a3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6735ad7a8872330008858949

@jonathan-innis jonathan-innis enabled auto-merge (squash) November 14, 2024 07:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11832987945

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.689%

Totals Coverage Status
Change from base Build 11832596406: 0.0%
Covered Lines: 5665
Relevant Lines: 6851

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 569c06d into aws:main Nov 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants