replace ipv6 prefix with ipv6 address #7391
Merged
+24
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
haouc
force-pushed
the
ipv6
branch
8 times, most recently
from
4e5b96a
to
77719da
Compare
Pull Request Test Coverage Report for Build 11872481614Details
💛 - Coveralls |
jonathan-innis
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Since EC2 doesn't support primaryIPv6 and IPv6 prefix, we have to switch to IPv6 /128 address with primary IPv6 as true. Also we should remove the
AssociatePublicIPAddressfrom the if check since the provisioned network interface by default with a instance won't be different from what we set in the if block.How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.