Add scripts to generate Release note #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2024 20:48
| help="Specify the target patch version for which the release needs to be generated.", | ||
| ) | ||
| package_release_parser.add_argument( | ||
| "--image-type", |
There was a problem hiding this comment.
Are we doing 2 separate github releases, 1 for each image type?
There was a problem hiding this comment.
Yes, it was decided in meeting with PM. Reason is in the future we may have release for other platform like trainium
src/image_version.py
Outdated
| @@ -0,0 +1,27 @@ | |||
| class ImageVersion: | |||
| def __init__(self, image_full_version: str, image_type: str): | |||
There was a problem hiding this comment.
can we accomplish this functionality using the semver Version class ? I just think it might be a little confusing to be using both in different places in the package
aws-tianquaw
reviewed
Oct 3, 2024
src/main.py
Outdated
| @@ -442,6 +443,21 @@ def get_arg_parser(): | |||
| required=True, | |||
| help="Specify the target patch version for which the package dependency report needs to be generated.", | |||
| ) | |||
| package_release_parser = subparsers.add_parser( | |||
| "generate-version-release", | |||
There was a problem hiding this comment.
Can we rename this command to be "generate-version-release-note"? It's a little confusing to me because it could indicate generating build artifacts for a new image version
src/image_version.py
Outdated
| @@ -0,0 +1,27 @@ | |||
| class ImageVersion: | |||
| def __init__(self, image_full_version: str, image_type: str): | |||
added 2 commits
October 3, 2024 19:13
aws-tianquaw
approved these changes
Oct 3, 2024
claytonparnell
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add scripts to generate Release note, it's part of auto notification task. Will make change to these content if PM shares feedback later.
Test
Unit test and Example release: https://github.com/aws/sagemaker-distribution/releases/tag/1.11.0-gpu
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.