Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix model explainability one time schedule #4435

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hightensan
Copy link

Issue #, if available:
Fix for - #4431

Description of changes:

  • Add data_analysis_start_time and data_analysis_end_time in ModelExplainabilityMonitor's _create_monitoring_schedule_from_job_definition
  • Add unit test code test_model_explainability_monitor_with_one_time_schedule and _test_model_explainability_monitor_create_one_time_schedule to test ModelExplainabilityMonitor's one-time schedule

Testing done:

  • Unit test done as $ tox -e py39 -- -s -vv tests/unit/sagemaker/monitor/test_clarify_model_monitor.py::test_model_explainability_monitor_with_one_time_schedule

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hightensan hightensan requested a review from a team as a code owner February 17, 2024 13:13
@hightensan hightensan requested review from benieric and removed request for a team February 17, 2024 13:13
@hightensan hightensan changed the title Fix model explainability one time schedule fix: Fix model explainability one time schedule Mar 3, 2024
@benieric benieric self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.25%. Comparing base (8b206ba) to head (9203b62).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4435      +/-   ##
==========================================
+ Coverage   86.94%   87.25%   +0.31%     
==========================================
  Files        1203      388     -815     
  Lines      107211    36363   -70848     
==========================================
- Hits        93211    31729   -61482     
+ Misses      14000     4634    -9366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benieric
Copy link
Contributor

benieric commented Mar 12, 2024

please run tox -e black-format to fix codestyle-doc-tests formatting issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants