Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use sagemaker session's s3 resource for downloading folders #4664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DarrenStack
Copy link

Issue #, if available:
#4663

Description of changes:
Uses the s3 resource that is created as part of the sagemaker session instead of making a new one.
Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DarrenStack DarrenStack requested a review from a team as a code owner May 8, 2024 10:42
@DarrenStack DarrenStack requested review from benieric and removed request for a team May 8, 2024 10:42
benieric
benieric previously approved these changes May 10, 2024
@DarrenStack
Copy link
Author

Apologies for the close and re-open. I noticed the issue behaviour happens in both the download_file and download_folder functions but when updating I pushed before making the commit 🙃 which auto-closed the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants