Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable quantization and compilation in the same optimization job via ModelBuilder and add validations to prevent compilation for Llama-3.1 on TRTLLM. #4875

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cj-zhang
Copy link
Contributor

@cj-zhang cj-zhang commented Sep 18, 2024

…ModelBuilder.

Issue #, if available:

Description of changes: TRTLLM containers allow compilation and quantization at the same time, so the validations to ensure mutual exclusivity must be removed. Compilation using Llama-3.1 on TRTLLM v11 also doesn't currently work, so adding validations to prevent those jobs from being created.

Testing done: New and updated unit tests on jumpstart_builder and model_builder. Locally tested TRTLLM/Llama-3.1 validations from both JS and HF flow.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cj-zhang cj-zhang requested a review from a team as a code owner September 18, 2024 00:45
@cj-zhang cj-zhang changed the title bugfix: Enable quantization and compilation in the same optimization job via ModelBuilder. fix: Enable quantization and compilation in the same optimization job via ModelBuilder. Sep 18, 2024
@cj-zhang cj-zhang changed the title fix: Enable quantization and compilation in the same optimization job via ModelBuilder. fix: Enable quantization and compilation in the same optimization job via ModelBuilder and add validations to prevent compilation for Llama-3.1 on TRTLLM. Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants