test: assert that PLogMetadata is NotNil in partial test #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wesley Pettit <[email protected]>
garmikea
approved these changes
Apr 26, 2022
aaithal
approved these changes
Apr 27, 2022
kzys
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Looks good to me.
@aaithal or @JoseVillalta Can you re-run the failed test. It should pass... Also I don't have permissions to merge PRs. So you folks should merge the PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wesley Pettit [email protected]
This just ensures that if we ever break the partial metadata feature, the test will fail with a nice error on this new line, instead of failing with a null pointer exception.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.