Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET v3: Fix for bug with StepFunctions example, fixes #5745. #5746

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

rlhagerm
Copy link
Contributor

@rlhagerm rlhagerm commented Dec 5, 2023

This pull request fixes an issue with the request initialization in the .NET StepFunctions example. It also updates the README and fixes code warnings for the linter.

Closes #5745

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added DotNet-v3 This issue relates to the AWS SDK for .NET V3 Tools This issue relates to a custom tooling to streamline development tasks labels Dec 5, 2023
@rlhagerm rlhagerm self-assigned this Dec 5, 2023
@rlhagerm rlhagerm added Text Review not needed This contains no text which needs review Bug An update to fix incorrect code or typos. Task A general update to the code base for language clarification, missing actions, tests, etc. and removed Tools This issue relates to a custom tooling to streamline development tasks labels Dec 5, 2023
@rlhagerm rlhagerm requested review from a team and cpyle0819 and removed request for a team December 5, 2023 16:42
Copy link
Contributor

@cpyle0819 cpyle0819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No comments.

@rlhagerm rlhagerm added the On Call Review needed This work needs an on-call review label Dec 5, 2023
@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Dec 8, 2023
@ford-at-aws ford-at-aws force-pushed the dotnet-stepfunctions-bugfix branch from 9c8434e to e470a23 Compare December 8, 2023 14:19
@github-actions github-actions bot added the Tools This issue relates to a custom tooling to streamline development tasks label Dec 8, 2023
@ford-at-aws ford-at-aws merged commit 8a1f512 into awsdocs:main Dec 8, 2023
9 checks passed
meyertst-aws pushed a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Jan 4, 2024
@rlhagerm rlhagerm deleted the dotnet-stepfunctions-bugfix branch January 9, 2024 17:45
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An update to fix incorrect code or typos. DotNet-v3 This issue relates to the AWS SDK for .NET V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review Tools This issue relates to a custom tooling to streamline development tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: .NET Step Functions issue
3 participants