New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python - CloudWatch Logs - Large query implementation #6038

Closed

ford-at-aws wants to merge 24 commits into main from largequery

Contributor

ford-at-aws commented Feb 2, 2024

This PR implements the Python cloudwatch story: #5865.

ford-at-aws added the Task label

ford-at-aws requested a review from rlhagerm

February 2, 2024 18:19

ford-at-aws self-assigned this

github-actions bot added the Python label

rlhagerm requested changes

View reviewed changes

Contributor

rlhagerm left a comment

I think there should also be metadata so the scenario shows up under CloudWatch logs. Tested and the scenario ran as expected.

python/example_code/cloudwatch-logs/scenarios/large-query/README.md Show resolved Hide resolved

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py Outdated Show resolved Hide resolved

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py Outdated Show resolved Hide resolved

python/example_code/cloudwatch-logs/scenarios/large-query/README.md Outdated Show resolved Hide resolved

python/example_code/cloudwatch-logs/scenarios/large-query/test/test_large_query.py Outdated Show resolved Hide resolved

rlhagerm reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/test/test_large_query.py Show resolved Hide resolved

github-actions bot added the Javascript-v3 label

rlhagerm reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py Outdated Show resolved Hide resolved

rlhagerm approved these changes

View reviewed changes

ford-at-aws force-pushed the largequery branch from 8b307ee to 92c122b Compare

February 7, 2024 16:38

ford-at-aws added the On Call Review needed label

cpyle0819 reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/date_utilities.py Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/date_utilities.py Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py Outdated Show resolved Hide resolved

cpyle0819 removed the On Call Review needed label

ford-at-aws commented

View reviewed changes

.doc_gen/metadata/cloudwatch-logs_metadata.yaml Outdated Show resolved Hide resolved

ford-at-aws force-pushed the largequery branch from 737011a to 77edf10 Compare

February 19, 2024 15:32

cpyle0819 approved these changes

View reviewed changes

python/example_code/cloudwatch-logs/scenarios/large-query/cloudwatch_query.py

+                              args=((most_recent_log_timestamp, midpoint),),
+                          )
+                          second_half_thread = threading.Thread(
+                              target=self.recursive_query, args=((midpoint, date_range[1]),)

Contributor

cpyle0819 Feb 19, 2024

midpoint is used twice without incrementing it. Will this return duplicate logs?

DavidSouther force-pushed the main branch from 6ab9372 to f807d60 Compare

February 19, 2024 18:23

ford-at-aws force-pushed the largequery branch from f4c003a to a8d1097 Compare

February 20, 2024 18:51

github-actions bot added Kotlin Java-v2 labels

ford-at-aws force-pushed the largequery branch from a8d1097 to f4c003a Compare

February 20, 2024 18:54

github-actions bot added Ruby Swift GitHub settings labels

ford-at-aws force-pushed the largequery branch from f4c003a to 06d2ed1 Compare

February 20, 2024 18:58

github-actions bot removed Swift GitHub settings labels

meyertst-aws and others added 24 commits

February 20, 2024 14:03


          CPP: Fix mocks for weathertop (#6124)

b578fec

* Fixing mocks to handle credentials request

Java V2 Add sample files and update POM files (#6115)

* add sample files

* updated POM

* updated POM

* updated POM

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* update a test

* update a test

* update folder name

* update sample files

* update sample files

* update java file

Add sample files for kotlin (#6122)

This PR has updated some Kotlin files, Linter issues, and added digital assets to a folder under kotlin so all tests can find dependant files, such as image files.  All Kotlin tests have successfully executed.


          Working prototype

319f7a3


          Finished version, Still need edits

68784e2


          improving code comments

5f12509


          testing

025d1f8


          black

dd7be45


          updates

800b9be


          Update README.md

bd4c986


          updates

5a44b73


          formatting and adding new tag for integ

82964b1


          added docstring for process logs method

d549cfa


          added docstring for get_recent_logs method

c82594c


          logs metadata for workflow

f410e3d


          Adding new method to help with testing

9828d30


          Setting time to UTC

03c48b8

fix

c7551dd


          adding to metadata

8f2c253


          log detail

b71cb70


          linting

2c283c4


          8601 and kill line

b36ccd3


          Performance improvements

6670fae


          Formatting

804b67d


          Formatting

0f08cc8


          Formatting

8a7b8ef

ford-at-aws force-pushed the largequery branch from 06d2ed1 to 8a7b8ef Compare

February 20, 2024 19:04

github-actions bot added the C++ label

ford-at-aws closed this

ford-at-aws deleted the largequery branch

February 21, 2024 13:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ Java-v2 Javascript-v3 Kotlin Python Task