Swift: Update getting started example to build on Mac #6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepazon
added
On Call Review needed
shepazon
requested review from
a team and
DavidSouther
and removed request for
a team
shepazon
changed the title
DavidSouther
approved these changes
Feb 13, 2024
scmacdon
added
On Call Review complete
Fixed some minor issues preventing Mac builds of the ListBuckets-Simple S3 example. These changes will need to be replicated across all examples, but this is being pushed first because it is a dependency of a documentation update. This example is embedded in fragments inline in the Swift SDK developer guide's "Get started" page. *Changes* * Added the `platforms` block to the `Package.swift` file. This is needed to build for Apple platforms, and was removed from all examples by mistake during a cleanup pass many months ago. * Renamed the `main.swift` file to `entry.swift`. This works around a known bug in the Swift build chain when the main program uses asynchronous code.
scmacdon
force-pushed
the
fix-package-files
branch
from
1bafde1 to
ff6f1e8
Compare
|
This commit message looks fine. |
DavidSouther
pushed a commit
to DavidSouther/aws-doc-sdk-examples
that referenced
this pull request
Feb 19, 2024
Update example for getting started to build on Mac Fixed some minor issues preventing Mac builds of the ListBuckets-Simple S3 example. These changes will need to be replicated across all examples, but this is being pushed first because it is a dependency of a documentation update. This example is embedded in fragments inline in the Swift SDK developer guide's "Get started" page. *Changes* * Added the `platforms` block to the `Package.swift` file. This is needed to build for Apple platforms, and was removed from all examples by mistake during a cleanup pass many months ago. * Renamed the `main.swift` file to `entry.swift`. This works around a known bug in the Swift build chain when the main program uses asynchronous code.
cpyle0819
pushed a commit
to DennisTraub/aws-doc-sdk-examples
that referenced
this pull request
Feb 19, 2024
Update example for getting started to build on Mac Fixed some minor issues preventing Mac builds of the ListBuckets-Simple S3 example. These changes will need to be replicated across all examples, but this is being pushed first because it is a dependency of a documentation update. This example is embedded in fragments inline in the Swift SDK developer guide's "Get started" page. *Changes* * Added the `platforms` block to the `Package.swift` file. This is needed to build for Apple platforms, and was removed from all examples by mistake during a cleanup pass many months ago. * Renamed the `main.swift` file to `entry.swift`. This works around a known bug in the Swift build chain when the main program uses asynchronous code.
max-webster
pushed a commit
to max-webster/aws-doc-sdk-examples
that referenced
this pull request
Mar 15, 2024
Update example for getting started to build on Mac Fixed some minor issues preventing Mac builds of the ListBuckets-Simple S3 example. These changes will need to be replicated across all examples, but this is being pushed first because it is a dependency of a documentation update. This example is embedded in fragments inline in the Swift SDK developer guide's "Get started" page. *Changes* * Added the `platforms` block to the `Package.swift` file. This is needed to build for Apple platforms, and was removed from all examples by mistake during a cleanup pass many months ago. * Renamed the `main.swift` file to `entry.swift`. This works around a known bug in the Swift build chain when the main program uses asynchronous code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some minor issues preventing Mac builds of the ListBuckets-Simple S3
example. These changes will need to be replicated across all examples, but
this is being pushed first because it is a dependency of a documentation
update. This example is embedded in fragments inline in the Swift SDK
developer guide's "Get started" page.
Changes
platformsblock to thePackage.swiftfile. This is needed tobuild for Apple platforms, and was removed from all examples by mistake
during a cleanup pass many months ago.
main.swiftfile toentry.swift. This works around a knownbug in the Swift build chain when the main program uses asynchronous code.
This pull request...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.