CPP: Fix testing false negatives #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
C++
meyertst-aws
requested review from
ford-at-aws
and removed request for
a team
ford-at-aws
approved these changes
Feb 15, 2024
meyertst-aws
force-pushed
the
fix_testing_mock
branch
from
0765cd3 to
5f0e4d0
Compare
scmacdon
approved these changes
Feb 15, 2024
scmacdon
added
On Call Review complete
scmacdon
force-pushed
the
fix_testing_mock
branch
from
5f0e4d0 to
2971412
Compare
max-webster
pushed a commit
to max-webster/aws-doc-sdk-examples
that referenced
this pull request
Mar 15, 2024
Adding some code to mock credentials request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue when mocks run in Weathertop.
It adds a mock for credential requests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.