-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPP: Fix mocks for weathertop #6124
Merged
meyertst-aws
merged 5 commits into
awsdocs:main
from
meyertst-aws:fix_mocks_for_weathertop
Feb 19, 2024
Merged
CPP: Fix mocks for weathertop #6124
meyertst-aws
merged 5 commits into
awsdocs:main
from
meyertst-aws:fix_mocks_for_weathertop
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
C++
This issue relates to the AWS SDK for C++
Text Review not needed
This contains no text which needs review
Task
A general update to the code base for language clarification, missing actions, tests, etc.
labels
Feb 16, 2024
meyertst-aws
requested review from
DavidSouther
and removed request for
a team
February 16, 2024 18:19
DavidSouther
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance this could be pulled into a library or shared location, rather than duplicated per example?
meyertst-aws
force-pushed
the
fix_mocks_for_weathertop
branch
from
February 19, 2024 19:35
319c442
to
e06a740
Compare
meyertst-aws
force-pushed
the
fix_mocks_for_weathertop
branch
from
February 19, 2024 20:12
17aa2ba
to
1ac49c9
Compare
ford-at-aws
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Fixing mocks to handle credentials request Java V2 Add sample files and update POM files (#6115) * add sample files * updated POM * updated POM * updated POM * updated POM files * updated POM files * updated POM files * updated POM files * updated POM files * updated POM files * updated POM files * updated POM files * update a test * update a test * update folder name * update sample files * update sample files * update java file Add sample files for kotlin (#6122) This PR has updated some Kotlin files, Linter issues, and added digital assets to a folder under kotlin so all tests can find dependant files, such as image files. All Kotlin tests have successfully executed.
max-webster
pushed a commit
to max-webster/aws-doc-sdk-examples
that referenced
this pull request
Mar 15, 2024
* Fixing mocks to handle credentials request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C++
This issue relates to the AWS SDK for C++
On Call Review complete
On call review complete
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Text Review not needed
This contains no text which needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the testing mocks to handle credential requests in the Weathertop environment
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.