Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP: Fix mocks for weathertop #6124

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

meyertst-aws
Copy link
Contributor

This fixes the testing mocks to handle credential requests in the Weathertop environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added C++ This issue relates to the AWS SDK for C++ Text Review not needed This contains no text which needs review Task A general update to the code base for language clarification, missing actions, tests, etc. labels Feb 16, 2024
@meyertst-aws meyertst-aws requested a review from a team February 16, 2024 18:19
@meyertst-aws meyertst-aws self-assigned this Feb 16, 2024
@meyertst-aws meyertst-aws requested review from DavidSouther and removed request for a team February 16, 2024 18:19
Copy link
Contributor

@DavidSouther DavidSouther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this could be pulled into a library or shared location, rather than duplicated per example?

cpp/example_code/autoscaling/tests/autoscaling_gtests.cpp Outdated Show resolved Hide resolved
@meyertst-aws meyertst-aws force-pushed the fix_mocks_for_weathertop branch from 17aa2ba to 1ac49c9 Compare February 19, 2024 20:12
@meyertst-aws meyertst-aws merged commit 2af2e03 into awsdocs:main Feb 19, 2024
9 checks passed
@meyertst-aws meyertst-aws deleted the fix_mocks_for_weathertop branch February 19, 2024 20:24
ford-at-aws pushed a commit that referenced this pull request Feb 20, 2024
* Fixing mocks to handle credentials request

Java V2 Add sample files and update POM files (#6115)

* add sample files

* updated POM

* updated POM

* updated POM

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* updated POM files

* update a test

* update a test

* update folder name

* update sample files

* update sample files

* update java file

Add sample files for kotlin (#6122)

This PR has updated some Kotlin files, Linter issues, and added digital assets to a folder under kotlin so all tests can find dependant files, such as image files.  All Kotlin tests have successfully executed.
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
* Fixing mocks to handle credentials request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants