Cpp: multi-service, add pagination #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
C++
meyertst-aws
force-pushed
the
6219-c++-pagination-tech-debt
branch
from
0f3f506 to
3de227d
Compare
DavidSouther
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
In general, this looks fine & how I'd expect. It's already a big change, so I don't want to suggest much more structural issues, but... it looks like a lot of the examples could get cleaned up using auto. On the other hand, if you're being explicit with types for examples, maybe the autos should be explicit? Regardless, it's about 50/50 which seems accidental/historical more than intentional.
DavidSouther
added
On Call Review complete
DavidSouther
force-pushed
the
6219-c++-pagination-tech-debt
branch
from
3de227d to
d17879e
Compare
DavidSouther
pushed a commit
to DavidSouther/aws-doc-sdk-examples
that referenced
this pull request
Apr 30, 2024
Adding pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pagination where misssing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.