-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples for the new Amazon Bedrock Converse API (Python, C#, JavaScript) #6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DotNet-v3
This issue relates to the AWS SDK for .NET V3
Go-v2
This issue relates to the AWS SDK for Go V2
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
PHP
This issue relates to the AWS SDK for PHP
Python
This issue relates to the AWS SDK for Python (boto3)
Java-v2
This issue relates to the AWS SDK for Java V2
SAP ABAP
This issue relates to the AWS SDK for SAP ABAP
labels
May 30, 2024
DennisTraub
force-pushed
the
converse
branch
2 times, most recently
from
May 31, 2024 14:29
648dc6d
to
33f3aad
Compare
cpyle0819
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for the new converse examples.
rlhagerm
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and requested changes in my review, thanks.
dotnetv3/Bedrock-runtime/Models/Ai21LabsJurassic2/Converse/Converse.csx
Outdated
Show resolved
Hide resolved
dotnetv3/Bedrock-runtime/Models/AmazonTitanText/Converse/Converse.csx
Outdated
Show resolved
Hide resolved
dotnetv3/Bedrock-runtime/Models/AmazonTitanText/InvokeModel/InvokeModel.csx
Outdated
Show resolved
Hide resolved
dotnetv3/Bedrock-runtime/Models/AnthropicClaude/Converse/Converse.csx
Outdated
Show resolved
Hide resolved
dotnetv3/Bedrock-runtime/Models/Mistral/ConverseStream/ConverseStream.csx
Outdated
Show resolved
Hide resolved
dotnetv3/Bedrock-runtime/Models/Mistral/InvokeModel/InvokeModel.csx
Outdated
Show resolved
Hide resolved
...drock-runtime/Models/Mistral/InvokeModelWithResponseStream/InvokeModelWithResponseStream.csx
Show resolved
Hide resolved
ford-at-aws
reviewed
Jun 3, 2024
python/example_code/bedrock-runtime/models/ai21_labs_jurassic2/invoke_model.py
Outdated
Show resolved
Hide resolved
ford-at-aws
approved these changes
Jun 3, 2024
This reverts commit 8affab1.
cpyle0819
reviewed
Jun 3, 2024
cpyle0819
reviewed
Jun 3, 2024
javascriptv3/example_code/bedrock-runtime/tests/converse.integration.test.js
Outdated
Show resolved
Hide resolved
rlhagerm
approved these changes
Jun 3, 2024
rlhagerm
requested changes
Jun 3, 2024
rlhagerm
approved these changes
Jun 4, 2024
cpyle0819
approved these changes
Jun 4, 2024
cpyle0819
added
On Call Review complete
On call review complete
Task
A general update to the code base for language clarification, missing actions, tests, etc.
labels
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DotNet-v3
This issue relates to the AWS SDK for .NET V3
Go-v2
This issue relates to the AWS SDK for Go V2
Java-v2
This issue relates to the AWS SDK for Java V2
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
On Call Review complete
On call review complete
PHP
This issue relates to the AWS SDK for PHP
Python
This issue relates to the AWS SDK for Python (boto3)
SAP ABAP
This issue relates to the AWS SDK for SAP ABAP
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds examples for the new Amazon Bedrock Converse API, released on May 30th, 2024 (see also https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-bedrock-new-converse-api).
It contains examples in C#, JavaScript, and Python. Furthermore, it contains additional examples for the InvokeModel and InvokeModelWithResponseStream API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.