Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add work-dir as cli parameter #26

Closed
wants to merge 0 commits into from
Closed

add work-dir as cli parameter #26

wants to merge 0 commits into from

Conversation

sharonxiaohanli
Copy link
Contributor

Issue #, if available:

22

Description of changes:

  1. add work-dir as an optional parameter, by default it's the current directory
  2. validate if the directory is valid.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sharonxiaohanli sharonxiaohanli linked an issue Apr 5, 2024 that may be closed by this pull request
pass in configurable work directory #22
Closed
tonykchen
tonykchen approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@tonykchen tonykchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A super useful feature 👍 LGTM!

@sharonxiaohanli sharonxiaohanli mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonykchen tonykchen tonykchen approved these changes

@bobbywlindsey bobbywlindsey Awaiting requested review from bobbywlindsey

@suyinw suyinw Awaiting requested review from suyinw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pass in configurable work directory
2 participants
@sharonxiaohanli @tonykchen