Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve coverage #62

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

tonykchen
Copy link
Contributor

@tonykchen tonykchen commented May 21, 2024

Issue #, if available:

Description of changes:

  • Removed Runner and moved all run logic to agenteval.plan
  • Added a thread lock to protect shared objects during Plan.run
  • Added an TestFailureError exception, which is raised when 1 or more tests fail
  • Invoke validate_directory as an option callback in the CLI
  • Renamed TestResult.success to TestResult.passed for clarity
  • Moved TargetResponse to targets.TargetResponse to keep modules organized
  • Changed target config type from bedrock-knowledgebase to bedrock-knowledge-base for consistency
  • Moved metrics calculations to agenteval.metrics
  • Add unit tests to bump coverage up to 93% (from 78%)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tonykchen tonykchen marked this pull request as ready for review May 21, 2024 23:03
@tonykchen tonykchen merged commit a87d486 into awslabs:main May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant