Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ice-lite #1754

Open
wants to merge 3 commits into
base: develop-pre-1.11.0
Choose a base branch
from
Open

Conversation

zhuker
Copy link
Contributor

@zhuker zhuker commented Jul 17, 2023

Issue #, if available:

Description of changes:
Support ice-lite

ice-lite is a minimal version of the ICE specification, intended for servers running on a public IP address.

ice-lite is easy to implement, requiring the media server to only answer incoming STUN binding requests and acting as a controlled entity in the ICE process itself. This simplicity makes it quite popular among implementations of [SFUs] and other media servers.

Support for ice-lite is announced in the SDP as a=ice-lite.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhuker zhuker mentioned this pull request Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (863a1a4) 48.64% compared to head (4215d43) 48.64%.
Report is 78 commits behind head on develop.

❗ Current head 4215d43 differs from pull request most recent head 39d4e01. Consider uploading reports for the commit 39d4e01 to get more accurate results

Files Patch % Lines
src/source/PeerConnection/PeerConnection.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1754   +/-   ##
========================================
  Coverage    48.64%   48.64%           
========================================
  Files           46       46           
  Lines        12099    12099           
========================================
  Hits          5886     5886           
  Misses        6213     6213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhuker
Copy link
Contributor Author

zhuker commented Jul 17, 2023

cc @sirknightj

@sirknightj sirknightj requested a review from disa6302 July 18, 2023 03:34
@sirknightj sirknightj added enhancement New feature or request contribution labels Jul 18, 2023
@disa6302
Copy link
Contributor

@zhuker ,

Thank you for your contribution. I would like to run some end to end tests locally before reviewing this PR. Will update here once I have that going.

Copy link

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

@github-actions github-actions bot added the Stale label Jan 29, 2024
@disa6302 disa6302 removed the Stale label Feb 1, 2024
Copy link

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

@github-actions github-actions bot added the Stale label Jul 31, 2024
@niyatim23 niyatim23 removed the Stale label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants