GCC CI Build Fixes #1861
Draft
GCC CI Build Fixes #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1861 +/- ##
===========================================
- Coverage 75.44% 75.22% -0.23%
===========================================
Files 49 48 -1
Lines 13930 12177 -1753
===========================================
- Hits 10510 9160 -1350
+ Misses 3420 3017 -403 ☔ View full report in Codecov by Sentry. |
|
Note to self: add comments in code explaining changes before merging. |
stefankiesz
commented
Dec 8, 2023
| wBioDataLen = (SIZE_T) BIO_get_mem_data(SSL_get_wbio(pTlsSession->pSsl), &wBioBuffer); | ||
| CHK_ERR(wBioDataLen >= 0, STATUS_SEND_DATA_FAILED, "BIO_get_mem_data failed"); | ||
| wBioGetMemDataRet = BIO_get_mem_data(SSL_get_wbio(pTlsSession->pSsl), &wBioBuffer); | ||
| CHK_ERR(wBioGetMemDataRet != 0, STATUS_SEND_DATA_FAILED, "BIO_get_mem_data failed with: no BIO was connected to the SSL object."); |
There was a problem hiding this comment.
Note: "0" is an error, was being treated as a non-error prior to these changes
There was a problem hiding this comment.
BIO_get_mem_data() returns the total number of bytes available on success, 0 if b is NULL, or a negative value in case of other errors.
stefankiesz
force-pushed
the
fix-gcc-mac-ci
branch
from
75afca4 to
3a780ac
Compare
This reverts commit 8af00c8.
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c:213:1: error: multi-line comment [-Werror=comment]
213 | // / \
| ^
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c:217:1: error: multi-line comment [-Werror=comment]
217 | // / \
| ^
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c: In function 'sctpSessionWriteDcep':
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c:249:51: error: comparison is always true due to limited range of data type [-Werror=type-limits]
249 | if (pRtcDataChannelInit->maxRetransmits.value >= 0 && pRtcDataChannelInit->maxRetransmits.isNull == FALSE) {
| ^~
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c:252:61: error: comparison is always true due to limited range of data type [-Werror=type-limits]
252 | } else if (pRtcDataChannelInit->maxPacketLifeTime.value >= 0 && pRtcDataChannelInit->maxPacketLifeTime.isNull == FALSE) {
| ^~
In file included from /Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/open-source/include/com/amazonaws/kinesis/video/client/Include.h:13,
from /Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/include/com/amazonaws/kinesis/video/webrtcclient/Include.h:20,
from /Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/../Include_i.h:27,
from /Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c:2:
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c: In function 'handleDcepPacket':
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c:318:66: error: comparison of integer expressions of different signedness: 'int' and 'SIZE_T' {aka 'long long unsigned int'} [-Werror=sign-compare]
318 | CHK((labelLength + protocolLength + SCTP_DCEP_HEADER_LENGTH) >= length, STATUS_SCTP_INVALID_DCEP_PACKET);
| ^~
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c: In function 'onSctpInboundPacket':
/Users/runner/work/amazon-kinesis-video-streams-webrtc-sdk-c/amazon-kinesis-video-streams-webrtc-sdk-c/src/source/Sctp/Sctp.c:336:12: error: variable 'retStatus' set but not used [-Werror=unused-but-set-variable]
336 | STATUS retStatus = STATUS_SUCCESS;
| ^~~~~~~~~
At top level:
cc1: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics
cc1: all warnings being treated as errors
make[2]: *** [CMakeFiles/kvsWebrtcClient.dir/src/source/Sctp/Sctp.c.o] Error 1
make[1]: *** [CMakeFiles/kvsWebrtcClient.dir/all] Error 2
make: *** [all] Error 2
Error: Process completed with exit code 2.
stefankiesz
force-pushed
the
fix-gcc-mac-ci
branch
from
2ce1f4d to
254f5a3
Compare
|
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
Updated the GCC path set in the Mac GCC CI build.
Why was it changed?
"gcc" is mapped to CLANG on Mac, so the build was using CLANG rather than GCC compiler.
How was it changed?
The full path to the GCC and G++ compiler was identified, and it replaced the "gcc" and "g++" in the respective environment variables.
What testing was done for the changes?
The CI is to run to verify that the correct compiler is used and that the test is passing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.