Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1991, #1453
What was changed?
sequenceNumberList
may go out of bounds but is hard to detect / won't cause a crash because in memory the next memory spot when we go out of bounds is into thevalidIndexList
, and unless it's size is zero (which is likely never the case) we will not actually go out of bounds but instead we will overwrite a value in the wrong list.Why was it changed?
How was it changed?
See What was changed section and the file diff.
What testing was done for the changes?
CI. [TODO] More targeted tests need to be added, will remove this once it has been added.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.