Memory Optimization - ICE Agent Stats (#1947) #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change params size * Use dyanmic allocation and flag for ice stats * Debug 1 * Revert "Debug 1" This reverts commit ad7d02f. * Revert "Use dyanmic allocation and flag for ice stats" This reverts commit bf9a2ee. * Working version * enable flag in samples * Add unit test * Fix bug * README for the flag * Update readme
stefankiesz
force-pushed
the
ice-memory-reduction-sk
branch
from
614099b
to
81d87b2
Compare
stefankiesz
changed the title
stefankiesz
changed the title
stefankiesz
changed the title
sirknightj
reviewed
Nov 5, 2024
sirknightj
reviewed
Nov 6, 2024
sirknightj
reviewed
Nov 6, 2024
unicornss
reviewed
Nov 6, 2024
| @@ -115,6 +116,10 @@ if (ENABLE_KVS_THREADPOOL) | |||
| add_definitions(-DENABLE_KVS_THREADPOOL) | |||
| endif() | |||
|
|
|||
| if (ENABLE_STATS_CALCULATION_CONTROL) | |||
There was a problem hiding this comment.
Would it be helpful to include a note explaining that this modification is for memory optimization, along with an estimate of the memory savings if this feature were disabled?
There was a problem hiding this comment.
I have "Disabling these stats may lead to reductions in memory use." in the ReadMe. Will leave this comment open so we can consider adding a memory saving estimation for all of these, perhaps after more testing is done?
unicornss
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
ENABLE_STATS_CALCULATION_CONTROLCMake option to support enabling/disabling stats at runtime.Why was it changed?
enableIceStatsvalue is used as intended, a compile-time flag is required to enable its use for run-time control over enabling/disabling stats.enableIceStatsin the case that it was not initialized.How was it changed?
#ifdef's were added to check for theENABLE_STATS_CALCULATION_CONTROLflag before using theenableIceStatsvalue.What testing was done for the changes?
ENABLE_STATS_CALCULATION_CONTROL=FALSE andenableIceStats=TRUEENABLE_STATS_CALCULATION_CONTROL=FALSE andenableIceStats=FALSEENABLE_STATS_CALCULATION_CONTROL=TRUE andenableIceStats=TRUEENABLE_STATS_CALCULATION_CONTROL=TRUE andenableIceStats=FALSEBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.