Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Optimization - Refactor TWCC (#1934) #2075

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

stefankiesz
Copy link
Contributor

@stefankiesz stefankiesz commented Nov 5, 2024

Issue #, if available:

What was changed?
(aside from the original's PR changes)

  • Removed the IceAgentStats-related change.

Why was it changed?

  • IceAgentStats changes have been handled in a separate PR..

How was it changed?

  • Removed the relevant line.

What testing was done for the changes?

  • Allowing for CI to pass.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Remove stackqueue usage

* Use hashtable instead..working logic

* Cleanup, increase hash table size, fix loop bug

* method 2, array of pointers

* Add rolling window

* rolling window with hashtable

* hash table with rw

* Fix bug

* Fix twcc unit test

* Cleanup rw logic

* Cleanup

* Cleanup logic

* Update README

* unused var fix

* Use defines for hash table size

* Address comments, disable TWCC by default

* readme

* Fix windows gst issue

* Comments
@stefankiesz stefankiesz marked this pull request as ready for review November 6, 2024 01:40
samples/Common.c Outdated Show resolved Hide resolved
tst/RtcpFunctionalityTest.cpp Show resolved Hide resolved
tst/RtcpFunctionalityTest.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants