Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: add schema to join for column comments #708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkellar3
Copy link

@mkellar3 mkellar3 commented Dec 8, 2023

Issue #, if available:
#707

Description of changes:
Add schema to the join condition when getting column comments to avoid getting column comments on table with same name from another schema

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@leisersohn leisersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the fix, it solves the bug mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants