Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third party licenses file #1062

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Update third party licenses file #1062

merged 5 commits into from
Oct 18, 2023

Conversation

yasminetalby
Copy link
Contributor

@yasminetalby yasminetalby commented Sep 27, 2023

Issue #, if available: #1060

Description of changes:
add MIT license for https://github.com/DaveGamble/cJSON

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4c0a9f5) 82.22% compared to head (fb53e53) 82.19%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
- Coverage   82.22%   82.19%   -0.03%     
==========================================
  Files          52       52              
  Lines        5647     5646       -1     
==========================================
- Hits         4643     4641       -2     
- Misses       1004     1005       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause
*/
/*
Amazon.com has chosen to use this file under the terms of the BSD-3-Clause license.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this line vanished?
I am not a lawyer
everything lawyery scares me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll send you a message on slack!

@yasminetalby yasminetalby marked this pull request as draft September 28, 2023 16:33
@yasminetalby yasminetalby marked this pull request as ready for review October 2, 2023 12:18
@jmklix jmklix merged commit f705c61 into main Oct 18, 2023
51 checks passed
@jmklix jmklix deleted the third-party-license-doc branch October 18, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants