Skip to content

Commit

Permalink
clean up comments
Browse files Browse the repository at this point in the history
  • Loading branch information
xiazhvera committed Oct 16, 2024
1 parent 871ae9b commit a0be9d2
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion include/aws/io/event_loop.h
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ struct aws_event_loop *aws_event_loop_new_default_with_options(
struct aws_allocator *alloc,
const struct aws_event_loop_options *options);

// DEBUG WIP We should expose or condense all these def specific function APIs and not make them
// TODO: We should expose or condense all these def specific function APIs and not make them
// defined specific. Consolidation of them should work and branched logic within due to all the
// arguments being the same. Let's move away from different API based on framework and instead
// raise an unsupported platform error or simply use branching in implementation.
Expand Down
2 changes: 1 addition & 1 deletion tests/channel_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ static int s_test_channel_connect_some_hosts_timeout(struct aws_allocator *alloc

aws_io_library_clean_up();

// DEBUG WIP, sleep to wait for reference release
// sleep to wait for reference release
aws_thread_current_sleep(1000000000);

return 0;
Expand Down
10 changes: 5 additions & 5 deletions tests/socket_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ static int s_test_socket_ex(

aws_event_loop_destroy(event_loop);

// DEBUG WIP, sleep to wait for reference release
// wait for socket ref count drop and released
aws_thread_current_sleep(1000000000);

return 0;
Expand Down Expand Up @@ -440,7 +440,7 @@ static int s_test_socket_udp_dispatch_queue(

ASSERT_SUCCESS(aws_socket_listen(&listener, 1024));
ASSERT_SUCCESS(aws_socket_start_accept(&listener, event_loop, s_local_listener_incoming, &listener_args));
// DEBUG WIP, sleep to wait for reference release
// wait for incoming listener come back
aws_thread_current_sleep(1000000000);

struct local_outgoing_args outgoing_args = {
Expand Down Expand Up @@ -581,7 +581,7 @@ static int s_test_socket_udp_dispatch_queue(

aws_event_loop_destroy(event_loop);

// DEBUG WIP, sleep to wait for reference release
// wait for socket ref count drop and released
aws_thread_current_sleep(5000000000);

return 0;
Expand Down Expand Up @@ -1616,7 +1616,7 @@ static int s_cleanup_in_accept_doesnt_explode(struct aws_allocator *allocator, v
aws_socket_clean_up(&outgoing);
aws_event_loop_destroy(event_loop);

// DEBUG WIP, sleep to wait for reference release
// wait for socket ref count drop and released
aws_thread_current_sleep(1000000000);

return 0;
Expand Down Expand Up @@ -1761,7 +1761,7 @@ static int s_cleanup_in_write_cb_doesnt_explode(struct aws_allocator *allocator,
aws_socket_clean_up(&listener);
aws_event_loop_destroy(event_loop);

// DEBUG WIP, sleep to wait for reference release
// wait for socket ref count drop and released
aws_thread_current_sleep(1000000000);

return 0;
Expand Down
2 changes: 1 addition & 1 deletion tests/tls_handler_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ static int s_tls_common_tester_clean_up(struct tls_common_tester *tester) {

aws_condition_variable_clean_up(&tester->condition_variable);
aws_mutex_clean_up(&tester->mutex);
// DEBUG WIP, sleep to wait for reference release
// wait for socket ref count drop and released
aws_thread_current_sleep(1000000000);

return AWS_OP_SUCCESS;
Expand Down

0 comments on commit a0be9d2

Please sign in to comment.