Adding option to control Content Behaviour in deployment #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wspi
commented
Nov 17, 2017
| @@ -52,9 +52,9 @@ | |||
|
|
|||
| <dependencies> | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
There was a problem hiding this comment.
It's probably better to upload the new aws-sdk to the jenkins maven repo and get it from there
wspi
commented
Nov 17, 2017
| @@ -492,7 +496,7 @@ public BuildStepMonitor getRequiredMonitorService() { | |||
| return BuildStepMonitor.STEP; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Removed the double **, maven wasn't getting along with this
Jmcfar
reviewed
Dec 19, 2017
| @@ -7,7 +7,7 @@ | |||
| </parent> | |||
|
|
|||
| <artifactId>codedeploy</artifactId> | |||
| <version>1.17-SNAPSHOT</version> | |||
There was a problem hiding this comment.
We do not adjust the version suffix. SNAPSHOT is for prereleases as we aggregate additional functionality, and then the automated plugin release process will handle removing this and pushing the untagged version to the appropriate release branch.
|
Hi! Thanks for the contribution. Did you perform any testing as part of the changes? If so it'd be helpful to include that in the PR. Are you OK with submitting this contribution under the Apache License 2.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably better to upload the new aws-sdk to the jenkins maven repo and get it from there