Rubocop + disable jruby 9.2 and arm64

awslabs · Sep 16, 2024 · 4ae9ca0 · 4ae9ca0
1 parent c674b1f
commit 4ae9ca0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -85,6 +85,8 @@ jobs:
             ruby: 2.5
           - arch: arm64
             ruby: 2.6
+          - arch: arm64
+            ruby: jruby-9.2
     # Some macos runners are x64, some are arm64, see: https://github.com/actions/runner-images#available-images
     runs-on: ${{ matrix.arch == 'x64' && 'macos-14-large' || 'macos-14' }}
     steps:

diff --git a/gems/aws-crt/lib/aws-crt/errors.rb b/gems/aws-crt/lib/aws-crt/errors.rb
@@ -52,7 +52,7 @@ def self.error_class(error_name)
       # This requires filtering non-safe characters from the constant
       # name and ensuring it begins with an uppercase letter.
       def self.error_class_constant(error_name)
-        error_name.to_s.gsub(/AWS_ERROR_/, '').split('_').map(&:capitalize).join
+        error_name.to_s.gsub('AWS_ERROR_', '').split('_').map(&:capitalize).join
       end
 
       def self.add_error_constant(constant)

diff --git a/gems/aws-crt/lib/aws-crt/native.rb b/gems/aws-crt/lib/aws-crt/native.rb
@@ -76,7 +76,7 @@ def self.array_to_native(array)
       #   = false)
       # 3. Creates a bang method that does not do automatic error checking.
       def self.attach_function(c_name, params, returns, options = {})
-        ruby_name = c_name.to_s.sub(/aws_crt_/, '').to_sym
+        ruby_name = c_name.to_s.sub('aws_crt_', '').to_sym
         raise_errors = options.fetch(:raise, true)
         options.delete(:raise)
         unless raise_errors