Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodule update #56

Merged
merged 2 commits into from
Oct 16, 2023
Merged

submodule update #56

merged 2 commits into from
Oct 16, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Oct 16, 2023 •
edited
Loading

To pick up fix from submodule for sigv4a on MacOS 14+

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mullermp
mullermp approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please investigate CI failure

@TingDaoK
Copy link
Contributor Author

TingDaoK commented Oct 16, 2023 •
edited
Loading

Please investigate CI failure

https://amzn-aws.slack.com/archives/C01JMGL8GQ2/p1697480694781509 I did and I guess they won't fix it anytime soon, try to get around the issue by using gcc instead

@mullermp mullermp merged commit adac5f0 into main Oct 16, 2023
13 checks passed
@mullermp mullermp deleted the submodule-update-dengket branch October 16, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mullermp mullermp mullermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingDaoK @mullermp